fix: resolve partial verse references in crossref popup via Sword#1342
Merged
karlkleinpaste merged 1 commit intoJul 5, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: resolve partial verse references in crossref popup via Sword
Problem
When a bookmark contains partially specified verse references such as:
Matt.17.20; 18.10; 23.13; Mark.7.15; 9.43,45; ...the popup menu was unable to resolve partial references like
18.10without their book context (Matt), causing navigation to random or incorrect verses.Fix
Instead of manually parsing the verse list string, the popup now passes the full key through Sword's
parse_verse_list()engine, which correctly resolves partial references contextually — exactly as is done in the default verse list behavior.A new C wrapper function
main_parse_verse_list()has been added insrc/main/sword.ccto expose this C++ backend functionality to the C code inbookmarks_treeview.c.Changes
src/main/sword.h/src/main/sword.cc: newmain_parse_verse_list()wrappersrc/gtk/bookmarks_treeview.c: replace manual parsing withmain_parse_verse_list()